Documentation and error handling for 'tree.order' option #41
Conversation
-Added @param with documentation -Added error handler - if user specifies order of incorrect length, stops function and throws error
|
Oh great it's failing everything now 😅 even worse than last time. Eyeballing the error messages it seems to be having trouble installing orchaRd 🤔 |
|
Ha, happens. If you use |
Hi Dan - sorry but I'm not really understanding. orchaRD is installed fine my end, it's just when I make the pull request on GitHub these issues arise. I am completely unsure how these checks are working but it seems to be something with the installation of orchaRd on the virtual machine the checks are running off, in my very naive understanding? |
- Added 'tree.order' parameter to the function (forgot before, doh!) -Minor correction for coping with tree.order=NULL - Removed extra bracket on line 103 (flagged by checkout) - Got ordering working properly by adding line to reorder factor levels for data_trim (as well as previous reordering of mod_table)
|
Alright with help of a friend @padpadpadpad think have figured out the error and implemented some other corrections to actually get it working...famous last words 🤞 |
|
You need to re-run devtools::document() to make sure the help page has your new parameter in. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 60.48% 60.32% -0.17%
==========================================
Files 9 9
Lines 615 620 +5
==========================================
+ Hits 372 374 +2
- Misses 243 246 +3
☔ View full report in Codecov by Sentry. |
|
seems to be running ok now just codecov couldn't check some lines I added but I think OK to merge pending one last brief check from you? |
|
@befriendabacterium This is looking good on my end so I'll merge. Thanks for adding that, and thanks @padpadpadpad for clarifying to Matt on what to do. |
-Added @param with documentation
-Added error handler - if user specifies order of incorrect length, stops function and throws error