Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split packet trace logging into separate feature #79

Closed
daniel5151 opened this issue Sep 24, 2021 · 0 comments · Fixed by #78
Closed

Split packet trace logging into separate feature #79

daniel5151 opened this issue Sep 24, 2021 · 0 comments · Fixed by #78
Assignees
@daniel5151
Milestone
0.6

Comments

@daniel5151
Copy link
Owner

At the moment, incoming packets get logged via this log::trace! statement, and outgoing packets are logged via this log::trace! statement.

The latter log statement requires allocating an output buffer in the ResponseWriter to stash the outgoing packet, and is currently gated behind a cfg(feature = "std") flag.

Instead, this bit of tracing functionality ought to be split off into a separate "trace-pkt" feature, with a dependency on alloc (as opposed to std).

This oversight was uncovered while looking into #77
@daniel5151 daniel5151 added this to the 0.6 milestone Sep 24, 2021
@daniel5151 daniel5151 self-assigned this Sep 24, 2021
@daniel5151 daniel5151 linked a pull request Sep 24, 2021 that will close this issue
Enable logging for responses with only alloc. #78
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel5151 daniel5151

Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Enable logging for responses with only alloc. gz/gdbstub
1 participant
@daniel5151