Enable logging for responses with only alloc.

[gz]

Description

Enable logging for responses (as discussed here #77)

API Stability

• This PR does not require a breaking API change

Checklist

• Implementation
  • cargo build compiles without errors or warnings
  • cargo fmt was run
  • All tests pass

[daniel5151]

Wow, just as I wrap up opening #79, I realize you've opened a PR fixing it. Thank you!

As per my suggestion in #79, instead of overloading the "alloc" feature here, can you add a new feature to Cargo.toml called "trace-pkt"? This feature would have a dependency on alloc, while not forcing this additional logging overhead on all alloc users.

You'd also want to cfg-gate the incoming packet trace statement, which is currently always enabled.

[daniel5151]

Ah, also, I'd make "trace-pkt" a on-by-default feature as well.

[daniel5151]

You'd also want to cfg-gate the incoming packet trace statement, which is currently always enabled.

i.e: please also feature = "trace-pkt" gate the following lines:

https://github.com/daniel5151/gdbstub/blob/dev/0.6/src/protocol/recv_packet.rs#L56-L59
https://github.com/daniel5151/gdbstub/blob/dev/0.6/src/protocol/recv_packet.rs#L114-L117

EDIT: aaaand you beat me to the punch again 😅

[gz]

You'd also want to cfg-gate the incoming packet trace statement, which is currently always enabled.

I think I did this in 9e060d2 but let me know if I missed something.

[daniel5151]

Awesome, thanks again!