core_impl: fix support for no threads #127
Conversation
src/stub/core_impl/base.rs
Outdated
| None => { | ||
| res.write_str("E01")?; | ||
| return Ok(HandlerStatus::Handled); | ||
| } |
There was a problem hiding this comment.
I actually have a bit of plumbing in place to streamline returning Exx-style errors:
| None => { | |
| res.write_str("E01")?; | |
| return Ok(HandlerStatus::Handled); | |
| } | |
| None => return Err(Error::NonFatalError(1)) |
It's both more concise than invoking write_str + returning early, and also results in some slightly better codegen (wrt. binary size).
Can you switch both blocks over?
There was a problem hiding this comment.
Sure, I've made this change and pushed the result.
There was a problem hiding this comment.
Seems this change got lost somewhere?
|
Oh, also: can you mark the I'll spin up a tracking issue to remove it entirely in 0.7 |
|
Alright, I also marked |
xobs
force-pushed
the
fix-noactivethreads-error
branch
from
741b84a
to
be7439e
Compare
src/target/ext/base/multithread.rs
Outdated
|
|
||
| /// Allow the target to change the active PID from the default fake one. | ||
| #[inline(always)] | ||
| fn active_pid(&mut self) -> Result<Pid, Self::Error> { |
There was a problem hiding this comment.
It seems you lumped together your two PRs and lost some stuff along the way...
Lets keep this PR focused on solving the bug at hand, and leave this stuff to #129
src/stub/core_impl/base.rs
Outdated
| None => { | ||
| res.write_str("E01")?; | ||
| return Ok(HandlerStatus::Handled); | ||
| } |
There was a problem hiding this comment.
Seems this change got lost somewhere?
This variant is no longer generated, so note that it will be removed. Signed-off-by: Sean Cross <sean@xobs.io>
xobs
force-pushed
the
fix-noactivethreads-error
branch
from
be7439e
to
55e6ed2
Compare
Sometimes, a target has no threads. This may be the case when a process is not yet selected, or when all threads have terminated in a specific process. Support `None` as a return from `get_sane_any_tid()` and return an error to GDB. This addresses a `NoActiveThreads` error, and closes daniel5151#122. Signed-off-by: Sean Cross <sean@xobs.io>
Since this plumbing exists, use this to return an error. Signed-off-by: Sean Cross <sean@xobs.io>
|
It's been confusing because I need both PRs on my branch in order to do development, even though they are necessarily different features. I think I've got it sorted now and it should be all set for merging. |
Sometimes, a target has no threads. This may be the case when a process is not yet selected, or when all threads have terminated in a specific process.
Support
Noneas a return fromget_sane_any_tid()and return an error to GDB. This addresses aNoActiveThreadserror, and closes #122.