Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'read/write register' commands #22

Merged
merged 8 commits into from
Sep 9, 2020
Merged

Add 'read/write register' commands #22

merged 8 commits into from
Sep 9, 2020

Commits on Sep 5, 2020

  1. add 'read register' command of the RSP protocol 

    In some architecture, Gdb will actually query single
registers, for ex. on RISC-V. This commit introduces support for this
command.

To support this, several significant modifications are introduced:

- Add a `RegId` type in `Register` trait.
- the trait Target gained a new 'read_register' function, which is made optional
  to avoid breaking existing implementations.
    @thomashk0
    thomashk0 committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    d0e0fe8 View commit details
    Browse the repository at this point in the history

  2. complete implementation of the RegId trait for RISC-V 

    The RiscvRegId is now public in the arch::riscv::reg module.
    @thomashk0
    thomashk0 committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    a2862ab View commit details
    Browse the repository at this point in the history

  3. rewording docstrings of RegId and Register traits

    @thomashk0
    thomashk0 committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    fbdd3d4 View commit details
    Browse the repository at this point in the history

  4. add 'write register' command of the RSP protocol

    @thomashk0
    thomashk0 committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    e33d4b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. fix minor style issues in register read/write trait

    @thomashk0
    thomashk0 committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    090a638 View commit details
    Browse the repository at this point in the history

  2. send "E01" in case register write is not supported 

    This is more in line with GDB specifications of the 'P' packet.
    @thomashk0
    thomashk0 committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    b9a0918 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. implement single register write in the armv4t example 

    note: the 'P' handler now also reports an error if write_register is not
implemented.
    @thomashk0
    thomashk0 committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b37f622 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. implement read_register for the armv4t example

    @thomashk0
    thomashk0 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    6161d21 View commit details
    Browse the repository at this point in the history