Exclude test object files from package #37
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, portage. Now that's a name that bring back some Sure, this change seems perfectly reasonable. I've also gone ahead and removed the |
daniel5151
approved these changes
Nov 5, 2020
|
Thanks for the quick approval! Are you planning to release a new version with this PR? Then, I can remove a hack in our ChromeOS code base:) |
|
Sure 👍 Version |
|
Thanks a lot! I could just remove some workaround from the ebuild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude test object files such as
/examples/armv4t/test.owhen runningcargo package. I guess these data are not expected to be distributed to all gdbstub users.Also, excluding those files makes it easier to use this crate on the portage package manager, as it complains about prebuilt binaries and requires some hack .