Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire one-time login links #1

Open
danielbachhuber opened this issue Apr 28, 2016 · 4 comments · May be fixed by #37
Open

Expire one-time login links #1

danielbachhuber opened this issue Apr 28, 2016 · 4 comments · May be fixed by #37

Comments

@danielbachhuber
Copy link
Owner

Currently, the one-time login link lasts for as long as the plugin is active. We should probably expire the link at some point.

@shaneonabike
Copy link

I see that there is a --delay-delete now so this actually is already implemented and the issue can be closed.

@danielbachhuber
Copy link
Owner Author

--delay-delete is actually a little different: it means the token is deleted in 15 minutes after use, not immediately after use. The token is still valid for an indefinite period of time.

This issue is meant to only make the token valid for a specific period of time.

@masakik
Copy link

masakik commented May 16, 2023

Hi, I'm wondering if add an extra param to wp-cli --expiry=10, meaning that token will expire after 10 mins, independent of being used or not. It cam be achieved on function one_time_login_generate_tokens, using the same approach of delay-delete scheduling wp_schedule_single_event() for expiry time.
I can make a pull request with this, if interested.

@danielbachhuber
Copy link
Owner Author

@masakik Sure, I'd be open to a pull request for that!

masakik added a commit to masakik/one-time-login that referenced this issue Jun 14, 2023
@masakik masakik linked a pull request Jun 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants