perf(Cloak.Config.all/0): remove calls to ensure_loaded when checking… #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for ciphers
@danielberkompas I noticed a fairly significant slowdown in my test suite (229 => 590 secs) after updating cloak to 0.5.0. I tracked it down to the following lines. (that I myself added) I originally added the
ensure_loaded
as an additional safety check but it should not be necessary.On a separate note it may be useful to add a dummy cipher for testing so that we don't actually perform any expensive encrypting or decrypting calls. If you think that is a good idea, I will explore adding it to the codebase.