[#39] Fix function clause error

Closes #39.
danielberkompas · Sep 8, 2018 · 5621b3f · 5621b3f
1 parent a1fb889
commit 5621b3f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/lib/elasticsearch/exception.ex b/lib/elasticsearch/exception.ex
@@ -70,6 +70,18 @@ defmodule Elasticsearch.Exception do
     ]
   end
 
+  defp build(error, query) when is_map(error) do
+    [
+      status: nil,
+      line: nil,
+      col: nil,
+      message: error["message"],
+      type: nil,
+      query: query,
+      raw: error
+    ]
+  end
+
   defp build(error, query) when is_binary(error) do
     binary_error(error, query)
   end

diff --git a/test/elasticsearch/exception_test.exs b/test/elasticsearch/exception_test.exs
@@ -59,5 +59,26 @@ defmodule Elasticsearch.ExceptionTest do
                  query: nil
                )
     end
+
+    # See issue: https://github.com/infinitered/elasticsearch-elixir/issues/39
+    @tag :regression
+    test "handles arbitrary error maps" do
+      assert %Exception{type: nil, message: nil, query: nil, raw: %{"message" => nil}} =
+               Exception.exception(%{
+                 response: %{"message" => nil},
+                 query: nil
+               })
+
+      assert %Exception{
+               type: nil,
+               message: "Unable to connect to the server.",
+               query: nil,
+               raw: %{"message" => "Unable to connect to the server.", "ok" => false}
+             } =
+               Exception.exception(%{
+                 response: %{"message" => "Unable to connect to the server.", "ok" => false},
+                 query: nil
+               })
+    end
   end
 end