-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk "index" action and HEAD support #78
Bulk "index" action and HEAD support #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved when tests pass!
@danielberkompas thanks, I've changed the validation for |
It seems at least part of this functionality is covered under #68 We have a need to support delete actions as well in bulk, and would like to know which of the two PRs will be moving forward. |
We've added some onto this in the expectation this is merged. 😄 We'll PR once this is in. For reference, here's our changes compared to this branch: Bluetab/elasticsearch-elixir@feature/bulk-index-action...carsdotcom:decouple_bulk_action |
@danielberkompas is there anything preventing this being merged? thanks |
Hey @danielberkompas thank you for the great project, it's been really useful for us. Unfortunately I'm hitting the issue this changes seem to address. Does this PR need anything else to be merged? Thanks! |
@michelboaventura nothing else was needed, I just lost track of it! |
Thank you @danielberkompas! |
This PR includes support for the bulk "index" action (create or replace), while leaving "create" as the default.
I've also included support for HTTP HEAD requests, which Elasticsearch uses in various places (index exists, type exists, etc.)