This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Add image pasting functionality #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg this is so good. |
|
I love it. Thanks so much for your contributions @peterjosling |
Closed
|
This no longer works. Messenger.com has been updated to support image pasting (but not drag and drop?) — and in the process changed the private API I was using to send pasted data. |
Safari doesn't implement DataTransfer.items, so there's no way to extract image data (i.e. a screenshot copied to the clipboard) in Javascript. You can get copied files, but not data. Capture the paste in Swift and then forward on the image data to the webview. Currently supports pasting image data (and forwards on text), but pasting an image file doesn't work.
peterjosling
force-pushed
the
feature/image_paste
branch
from
050975b
to
59beeb3
Compare
|
Never mind, found the correct component again. Fixed. |
|
daniele can you release a new build? I feel so behind the times |
|
@peterjosling thank you so much for your amazing work and sorry for not merging this yet. I was super busy the last days, but I'll make a release this weekend! |
|
🎉🎉🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari doesn't implement DataTransfer.items, so there's no way to
extract image data (i.e. a screenshot copied to the clipboard) in
Javascript. You can get copied files, but not data. Capture the paste
in Swift and then forward on the image data to the webview.
Currently supports pasting image data (and forwards on text), but
pasting an image file doesn't work — when you try to paste a file it sends the icon instead. My Swift-fu isn't that great, so someone else will need to fix that.