Node does not move/update when given coordinates or new coordinates

[Kav91]

Describe the bug
If a node is on the map already, and it is given a X or Y coordinate, it will not update to its new location. Likewise if it already had an X/Y coordinate, and received new coordinates it will not update.
If you update the name of the Node however, it will update.

To Reproduce
Use the sandbox, generate a node, give it an x and/or y coordinate and save it.
It will not move to its new location, it will only move if the id attribute is updated as it thinks it is a new node most likely.

Expected behavior
When a node is given coordinates or new coordinates it should update and move into the appropriate location

[Kav91]

I see the issue is because the X and Y coordinates are in this white list: https://github.com/danielcaldas/react-d3-graph/blob/master/src/components/graph/graph.helper.js#L36

@danielcaldas is there any harm if we remove the X and Y coordinates from this whitelist?

[danielcaldas]

Safer would be to conditionaly skip the restore of x and y by allowing the client to provide the NODE_PROPS_WHITELIST. I think it could be a potential solution where you can defined what properties you want to keep from the state regardless the fact that they are being mutated.

On the other hand we could just do a dirty checking agains the x and y values provided by the client, and in case they change we can update them to the most recent client values of x and y.

Something along these lines...

nodes: data.nodes.map(n => {
        let { x, y } = state.nodes[n.id];
        const node = state.nodes[n.id] ? { ...n, ...pick(state.nodes[n.id], NODE_PROPS_WHITELIST) } : { ...n };
        const { x: clientX , y: clientY } = n;
        
        if (clientX) {
            node.x = clientX;
        }
        
        if (clientY) {
            node.y = clientY;
        }
        
        return node;
    }

I have currently no time to look at it, would you be up to giving it a try and submit a PR @Kav91 ?

Will scale priority according to the number of requests for this.

[BradleyBrown19]

This would be very useful!

[TranquilMarmot]

I've run into this as well; when a user moves a node around, the new position is persisted behind-the-scenes.

I also have undo/redo functionality and undo-ing a node's movement doesn't properly update the graph.

[piotrdelikat]

Being able to easily pass custom NODE_PROPS_WHITELIST would be helpful enough for me.