-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fx and fy when initializing nodes #353
Use fx and fy when initializing nodes #353
Conversation
links: [ | ||
{ source: "A", target: "B" }, | ||
{ source: "C", target: "A" }, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes in this file are just from running prettier 😄
In testing this locally it also seems to fix #295 |
@danielcaldas - Any idea when this can be merged and released? I tried with these changes in Just to give some context, we are also facing the issue #295. We have are using @TranquilMarmot - is there any work-around, until this fix is released? |
I have not found any workarounds for this, no. I'm currently using a locally-published version of this library with a bunch of changes merged in (basically, all the open PRs against this repo 😄 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @TranquilMarmot thanks for the change! Looks good 👍
fyi @piotrdelikat |
Thanks @danielcaldas and @TranquilMarmot. @danielcaldas - Is there any release planned in near future? |
There are a few more PRs in the pipeline before releasing a new version. Should still take a few weeks. Cheers! |
Fixes #350, fixes #295
Tested by setting
sandbox/data/default.js
to the following:Before this change,
node-3
would render in a different spot every time the page was refreshed.With this change it always renders at
300,300
.