Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The release version does not contain some fixes #314

Closed
NoMercy235 opened this issue Mar 28, 2020 · 3 comments
Closed

The release version does not contain some fixes #314

NoMercy235 opened this issue Mar 28, 2020 · 3 comments

Comments

@NoMercy235
Copy link

Describe the bug
The version you are currently downloading when installing from the npm does not contain some fixes. In particular, I was looking for this (found in the release logs of v2.4.0:

local link type added #247 (gopherine)

Others, too, may be missing.

To Reproduce
Steps to reproduce the behavior:

  1. Install the package via npm
  2. Try using the graph and set custom types for the input links.

Expected behavior
The links with the custom type should look accordingly

Screenshots
image
These two-way links should have their custom type set to CURVED_SMOOTH, but they still show up as STRAIGHT

Environment:
react-d4-version: 2.4.0

Additional context
I believe that the npm run dist script was not launched. I have cloned the repo locally, ran the script, and the lib/components/graph/graph.builder.js has a different output than what comes when installing via npm. In particular, there is the buildLinkProps function which is missing this line:

const type = link.type || config.link.type;

(and then the following usages of type)

@danielcaldas
Copy link
Owner

Hi @NoMercy235, maybe you're running against a cached version in your node_modules. I believe the current version was published to npm. Also if you take a look into the live sandbox you'll be able to use custom link.type.

@danielcaldas danielcaldas added the needs more info not enough proof to specify issue label Mar 29, 2020
@NoMercy235
Copy link
Author

Hey Daniel! I have just recently started using react-d3-graph, so I'm pretty sure there are no cache issues involved and that the installed version is indeed 2.4.0. I have also noticed that the setting does work in the sandbox, which was why I had to dig deeper into node_modules and see what was happening. This is how I noticed that the src/components/graph/graph.builder.js file looked different.

@NoMercy235
Copy link
Author

As stated in the #312 ticket, the update to v2.4.1 brought all the changes. Thanks!

Repository owner locked as resolved and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants