Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance control on links appearance - support dashed links #343

Closed
marcopiii opened this issue Jul 7, 2020 · 5 comments
Closed

Enhance control on links appearance - support dashed links #343

marcopiii opened this issue Jul 7, 2020 · 5 comments

Comments

@marcopiii
Copy link
Contributor

marcopiii commented Jul 7, 2020

Is your feature request related to a problem? Please describe.
The link configuration allows to customize just its color, opacity and width. It would be cool to have more control on the appearance of the links, like being able to draw dashed or dotted links.

Describe the solution you'd like
It's just a matter of allowing the Link component to accept supplementary svg presentation attributes and pass them to the generated <path> element as already doing with the already supported ones.

Describe your use case
In my specific case i need to draw dashed links.

Additional context
Most of the SVG presentation attributes would make no sense for the link (like fill), but i think that supporting stroke-dasharray, stroke-dashoffset and stroke-linecap would make perfectly sense. stroke-linejoin, stroke-miterlimit and others would make sense if the edges could be more complex than a single line.

@danielcaldas
Copy link
Owner

Thanks, that's a nice idea! I dropped a few comments in the PR. Once you address them we can move this forward. Let me know if you need any help.

@lifehackett
Copy link

@Aslug are you planning on making the changes to this PR? I'm looking for exactly this behavior. Thanks for the contribution!

@marcopiii
Copy link
Contributor Author

unfortunately i'm not able to follow this issue in the immediate future, feel free to fork the current changes and carry on the pr.

@danielcaldas
Copy link
Owner

Thanks for the heads up @Aslug @lironhl followed up with a PR for this one.

@danielcaldas
Copy link
Owner

Closed with #344

Repository owner locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants