Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow dashed links #397

Merged
merged 3 commits into from
Nov 30, 2020
Merged

allow dashed links #397

merged 3 commits into from
Nov 30, 2020

Conversation

lironhl
Copy link
Contributor

@lironhl lironhl commented Nov 14, 2020

Closes #344 and #343.

@lironhl lironhl force-pushed the feature/improve-control-on-link-appearance branch from 9f05f5f to a6b35b1 Compare November 14, 2020 21:29
danielcaldas
danielcaldas requested changes Nov 17, 2020
View reviewed changes
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a tiny change required. We're missing documentation for the new properties in the graph.config.js

src/components/graph/graph.config.js Show resolved Hide resolved
@lironhl lironhl force-pushed the feature/improve-control-on-link-appearance branch from edef48c to 06da4c6 Compare November 26, 2020 19:20
danielcaldas
danielcaldas approved these changes Nov 30, 2020
View reviewed changes
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielcaldas danielcaldas merged commit 0ac8c47 into danielcaldas:master Nov 30, 2020
@lironhl lironhl deleted the feature/improve-control-on-link-appearance branch November 30, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielcaldas danielcaldas danielcaldas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lironhl @danielcaldas @marcopiii