Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/not call graph configs inside component did update #10

Merged

Conversation

danielcaldas
Copy link
Owner

Place conditions to call following methods in componentDidUpdate:

  • _graphForcesConfig - Only called when new data (nodes and/or links) are passed into the component;
  • _zoomConfig - Only when new configurations are passed into the component.

Did some minor improvements including nodes and links validation on component bootstrap.

@danielcaldas danielcaldas merged commit bab2c93 into master Aug 4, 2017
@danielcaldas danielcaldas deleted the fix/not-call-graph-configs-inside-componentDidUpdate branch August 4, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant