Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/graph unnecessary calls to graph forces config #114

merged 8 commits into from Sep 29, 2018


Copy link

danielcaldas commented Sep 29, 2018

  • Graph does not tick anymore when config is updated or when some node/link property is updated
  • componentWillReceiveProps is @deprecated from react 16.3 onwards
  • Some npm scripts task improvements
  • Add antiPick to utils, could sound like overengineering (and it is) but I'm actually quite proud of the naming
  • Update some e2e tests
@danielcaldas danielcaldas merged commit 52df1b4 into master Sep 29, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@danielcaldas danielcaldas deleted the fix/graph-unnecessary-calls-to-graphForcesConfig branch Sep 30, 2018
zvolchak added a commit to zvolchak/react-d3-graph that referenced this pull request Oct 29, 2018
* Add deprecation note on componentWillReceiveProps

* Add antiPick method to utils

* Initialize links in initializeGraphState

* Add check:light task in package.json

* Implement checkForGraphElementsChanges in graph.helper

* e2e test collapse improvements

* Small check on number of links graph e2e

* Proper link initialization by mapping input to d3 link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.