Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #119 Add mouseCursor prop to <Link> #120

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

kaungmyatlwin
Copy link
Contributor

@kaungmyatlwin kaungmyatlwin commented Oct 2, 2018

For Hacktoberfest. Add feature #119 (sorry commit msg is prefixed as fix tho) mouseCursor prop to .

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just left some small comments about documentation

@@ -27,6 +27,7 @@ import React from 'react';
* stroke='green'
* className='link'
* opacity=1
* cursor='pointer'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mouseCursor

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

src/components/graph/graph.config.js Show resolved Hide resolved
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one comment on the file Link.jsx

@danielcaldas danielcaldas merged commit 382cd08 into danielcaldas:master Oct 3, 2018
@danielcaldas
Copy link
Owner

Merged! Nice job @kaungmyatlwin !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Hacktoberfest label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants