-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #119 Add mouseCursor prop to <Link> #120
fix: #119 Add mouseCursor prop to <Link> #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Just left some small comments about documentation
src/components/link/Link.jsx
Outdated
@@ -27,6 +27,7 @@ import React from 'react'; | |||
* stroke='green' | |||
* className='link' | |||
* opacity=1 | |||
* cursor='pointer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mouseCursor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed one comment on the file Link.jsx
Merged! Nice job @kaungmyatlwin !! |
For Hacktoberfest. Add feature #119 (sorry commit msg is prefixed as
fix
tho) mouseCursor prop to .