Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #119 Add mouseCursor prop to <Link> #120

Merged
merged 4 commits into from Oct 3, 2018

Conversation

@kaungmyatlwin
Copy link
Contributor

kaungmyatlwin commented Oct 2, 2018

For Hacktoberfest. Add feature #119 (sorry commit msg is prefixed as fix tho) mouseCursor prop to .

Kaung Myat Lwin added 2 commits Oct 2, 2018
Copy link
Owner

danielcaldas left a comment

Nice job! Just left some small comments about documentation

@@ -27,6 +27,7 @@ import React from 'react';
* stroke='green'
* className='link'
* opacity=1
* cursor='pointer'

This comment has been minimized.

Copy link
@danielcaldas

danielcaldas Oct 2, 2018

Owner

mouseCursor

This comment has been minimized.

Copy link
@danielcaldas

This comment has been minimized.

Copy link
@kaungmyatlwin

kaungmyatlwin Oct 3, 2018

Author Contributor

Got it.

src/components/graph/graph.config.js Show resolved Hide resolved
Kaung Myat Lwin
Copy link
Owner

danielcaldas left a comment

You missed one comment on the file Link.jsx

@danielcaldas danielcaldas merged commit 382cd08 into danielcaldas:master Oct 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas

This comment has been minimized.

Copy link
Owner

danielcaldas commented Oct 3, 2018

Merged! Nice job @kaungmyatlwin !!

zvolchak added a commit to zvolchak/react-d3-graph that referenced this pull request Oct 29, 2018
* fix: danielcaldas#119 Add mouseCursor prop to <Link>

* fix: Update Snapshot Testing for pointer

* doc: Add mouseCursor doc for Link

* doc: change to mouseCursor prop in Link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.