Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: Trigger custom click handler in collapsible nodes #137
Conversation
There was a mistake in the `_tick` method which caused the user's `onNodeClick` custom handler to never be triggered when the collapsible feature was enabled. The problem was that it called `setState` without using a callback parameter if the received `cb` was not empty. The contents of that ternary operator should be the opposite for things to work. This fix closes #136.
This comment has been minimized.
This comment has been minimized.
|
My bad! |
zvolchak
added a commit
to zvolchak/react-d3-graph
that referenced
this pull request
Oct 29, 2018
) * fix: Trigger custom click handler in collapsible nodes There was a mistake in the `_tick` method which caused the user's `onNodeClick` custom handler to never be triggered when the collapsible feature was enabled. The problem was that it called `setState` without using a callback parameter if the received `cb` was not empty. The contents of that ternary operator should be the opposite for things to work. This fix closes danielcaldas#136. * Add e2e test for node click callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
LonelyPrincess commentedOct 16, 2018
•
edited
There was a mistake in the
_tickmethod which caused the user'sonClickNodecustom handler to never be triggered when the collapsiblefeature was enabled.
The problem was that it called
setStatewithout using a callbackparameter if the received
cbwas not empty. The contents of thatternary operator should be the opposite for things to work.
This fix closes #136.