Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/allow custom properties to pass on update for links #220

Merged

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented Sep 3, 2019

This PR fixes the following:

  • Allows custom properties to be freely passed down on links.
  • Fixes the bug where removing a custom color from a link after adding it does not update the Graph.
  • Avoids ticking the graph when a link custom property such as the link.color is updated.
  • Adopts the same whitelist strategy to map client links data as the one used for nodes.
  • Adds the transform-object-rest-spread babel plugin replacing some usage of Object.assign by object spread operator.
  • Adds some more steps to e2e tests to ensure correct link updating behavior.
@danielcaldas danielcaldas changed the title Fix/allow custom properties to pass on update for links WIP: Fix/allow custom properties to pass on update for links Sep 3, 2019
@danielcaldas danielcaldas changed the title WIP: Fix/allow custom properties to pass on update for links Fix/allow custom properties to pass on update for links Sep 5, 2019
@danielcaldas danielcaldas merged commit 8c6fff3 into master Sep 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas danielcaldas deleted the fix/allow-custom-properties-to-pass-on-update-for-links branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.