Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncollapsing nodes causes entire graph to be dragged #224

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented Sep 5, 2019

This PR fixes #223.

  • Renamed _graphForcesConfig to _graphBindD3ToReactComponent, found this naming way more meaninful.
  • Splitted _graphBindD3ToReactComponent into two smaller independent units _graphLinkForceConfig and _graphNodeDragConfig.
  • When nodes are un-collasped (if this is even a word 馃槃) call _graphNodeDragConfig so that we bind revelated nodes with d3-drag.
鈥 so that bind can be granular. Run _graphNodeDragConfig when uncollapsing nodes.
@danielcaldas danielcaldas merged commit ba6a52b into master Sep 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas danielcaldas deleted the fix/cant-drag-node-after-uncollapsing branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.