Added callback for node position change. #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcaldas
requested changes
Sep 9, 2019
There was a problem hiding this comment.
Hey there @jiriproX! Thanks a lot for your contribution, I think this will give a lot more of power to users who want to track node position changes! There are just some small details we need to improve on the implementation, but overall is looking good.
Also if possible, would you mind adding a callback to the sandbox/Sandbox.jsx so that developers can see it in action in the [live demo(https://goodguydaniel.com/react-d3-graph/sandbox/index.html)? Nothing fancy just console.loging the node position when dragged.
|
Thanks for valuable comments. |
|
I can't find console.log output in "live demo". So, coordinates of changed position are not visible for me. |
danielcaldas
force-pushed
the
master
branch
from
bfdc811
to
c0ce37c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be used for storing of new node position after drag & drop of node.
Signed-off-by: Jiri Prokes jirix.x.prokes@intel.com