Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc refactor improvements #231

Merged
merged 16 commits into from Sep 14, 2019

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented Sep 14, 2019

  • Add @babel/plugin-proposal-optional-chaining.
  • Add settings.json.
  • Prune documentation.
  • Improve some e2e tests flakiness.
  • Fix problem with onNodePositionChange being called every time a node is clicked.
  • // FIXME: solve this source data inconsistency later - fix this by wrapping logic to extract id within a shared utility function, and documented the fact that source and target are dynamic in d3.
  • Use exports for utils and drop some other aliases imports for better development experience.
@danielcaldas danielcaldas merged commit d4bb534 into master Sep 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas danielcaldas deleted the refactor/misc-refactor-improvements branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.