Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc refactor improvements #231

Merged
merged 16 commits into from
Sep 14, 2019
Merged

Misc refactor improvements #231

merged 16 commits into from
Sep 14, 2019

Conversation

danielcaldas
Copy link
Owner

  • Add @babel/plugin-proposal-optional-chaining.
  • Add settings.json.
  • Prune documentation.
  • Improve some e2e tests flakiness.
  • Fix problem with onNodePositionChange being called every time a node is clicked.
  • // FIXME: solve this source data inconsistency later - fix this by wrapping logic to extract id within a shared utility function, and documented the fact that source and target are dynamic in d3.
  • Use exports for utils and drop some other aliases imports for better development experience.

@danielcaldas
Misc improvements in functions of collapse.helper.js
58fecfd
@danielcaldas
Remove some unncessary comments in utils.js
43f9445
@danielcaldas
Add some comments in graph.builder and misc refactoring
b94b5cb
@danielcaldas
Small misc improvements in graph.helper
307e4eb
@danielcaldas
Remove redundant comment in marker.helper
2be785b
@danielcaldas
Add some comments on optional chaining usage
9b59efc
@danielcaldas
Add ./vscode/settings.json
47bb442
@danielcaldas
Add babel plugin for optional chaining
f8d3914
@danielcaldas
Use optional chaining where it makes sense
54dec1b
@danielcaldas
Improve flakiness of e2e collapsible graph tests
870cfa5
@danielcaldas
Fix bug with onNodePositionChange. It was not reseting the value of t…
f4cfb12 
…he draggedNode on the state
@danielcaldas
Undo bad styles decision on sandbox
4fb41f1
@danielcaldas
Clear all timers in componentWillUnmont
e65db63
@danielcaldas
Improve id extraction from d3 links
30ca9f2
@danielcaldas
Improve exports. Not using default exports any more
41bd28f
@danielcaldas
Update README Contributions section
5670463
@danielcaldas danielcaldas merged commit d4bb534 into master Sep 14, 2019
@danielcaldas danielcaldas deleted the refactor/misc-refactor-improvements branch September 14, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielcaldas