Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Marker height and width configurable #245

Merged
merged 6 commits into from
Oct 7, 2019

Conversation

SachinVarghese
Copy link
Contributor

Related to issue #238

@SachinVarghese SachinVarghese changed the title Making Marker height and Width configurable Making Marker height and width configurable Oct 5, 2019
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @SachinVarghese, nice work! Just missing the declaration of the new properties in the graph.config.js (link in the codebase)

src/components/marker/Marker.jsx Outdated Show resolved Hide resolved
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a neat pick on the config file, I'll fix it myself

src/components/graph/graph.config.js Outdated Show resolved Hide resolved
src/components/marker/Marker.jsx Show resolved Hide resolved
@danielcaldas danielcaldas merged commit 3ef7be2 into danielcaldas:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants