node_label changes enabled local param for renderLabel #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcaldas
approved these changes
Nov 30, 2019
| @@ -206,7 +206,7 @@ function buildNodeProps(node, config, nodeCallbacks = {}, highlightedNode, highl | |||
| label, | |||
| opacity, | |||
| overrideGlobalViewGenerator: !node.viewGenerator && node.svg, | |||
| renderLabel: config.node.renderLabel, | |||
| renderLabel: node.renderLabel || config.node.renderLabel, | |||
There was a problem hiding this comment.
This will work just fine, basically, if no renderLabel is defined at node level we fallback to global 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#192 i added renderlabel it took so much time because i am not able to reproduce the problem in my local however i understand the problem of OP this i have made this changes.
Also regarding my earlier changes in this repo when i install the library i dont see the change i am still not able to change localLink but it works fine on the hosted example but not on my project
regards
Atharva