Don't throw error when there are no nodes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonelyPrincess
added
enhancement
LonelyPrincess
force-pushed
the
fix/warn-no-data-error
branch
from
ba02672
to
82be99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the process of graph data validation so that including at least a node is no longer mandatory.
If the user forgets to pass at least a node (or sets an empty node array in purpose) to the
Graphcomponent, they will not get an exception. Instead, a warning message will be displayed on console just to make them aware that they haven't added any node, in case they're not aware of it.Tests have been updated to check this new logic.
Should resolve #347.