Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/link highlight id number #74

Merged
merged 8 commits into from May 13, 2018

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented May 13, 2018

This PR addresses #73, next a brief description of what was done here:

  • Consistent data types (strings) passed into graph.helper buildLinkProps function;
  • Add new Sandbox functionality to allow different datasets (nodes and links data + config) to be loaded by changing url query params;
  • Add dataset with different initial configurations and graph data where node ids are of type number to replicate scenario in #73;
  • Add e2e tests for link (new tests) and add test for renderLabel node config;

NOTE: In the PR #69 the issue #73 was already fixed, this PR intent is to make it more consistent mainly by adding a e2e test case scenario where node ids are of type number and there we test all possible behaviours for link highlight.

@danielcaldas danielcaldas merged commit ee6c27a into master May 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas danielcaldas deleted the fix/link-highlight-id-number branch May 13, 2018
danielcaldas added a commit that referenced this pull request May 14, 2018
* Organize sandbox datasets under data folder. Add small dataset

* Bootstrap different config on sandbox via querystring

* Add different config to small dataset

* Add comment on Sandbox about queryParam scenario loading manipulation

* Fix graph and node e2e

* Add link.e2e

* Add e2e test for node.labelProperty

* Link props builder always receive source, target and highlightedNode as string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.