Fix/link highlight id number #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcaldas
added a commit
that referenced
this pull request
May 14, 2018
* Organize sandbox datasets under data folder. Add small dataset * Bootstrap different config on sandbox via querystring * Add different config to small dataset * Add comment on Sandbox about queryParam scenario loading manipulation * Fix graph and node e2e * Add link.e2e * Add e2e test for node.labelProperty * Link props builder always receive source, target and highlightedNode as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #73, next a brief description of what was done here:
graph.helperbuildLinkPropsfunction;numberto replicate scenario in BUG: NO LINK GETS HIGHLIGHTED WHEN NODE ID IS NON-STIRNG #73;renderLabelnode config;NOTE: In the PR #69 the issue #73 was already fixed, this PR intent is to make it more consistent mainly by adding a e2e test case scenario where node ids are of type
numberand there we test all possible behaviours for link highlight.