Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Graph fails to render without config prop #84

Merged
merged 1 commit into from
Jul 2, 2018
Merged

fix: Graph fails to render without config prop #84

merged 1 commit into from
Jul 2, 2018

Commits on Jun 28, 2018

  1. fix: Graph fails to render without config prop 

    When the user didn't add the 'config' prop to the 'Graph' component (which should be possible, as it's an optional field), the graph failed to render whenever its data changed.

The component would work the first time around, but when it received new data, it threw an error as described [in this issue](#81) and the view would not update.

The root of the problem was located in the `componentWillReceiveProps` method of the `Graph` component. When defining the constants `configUpdated` and `transform`, the case in which `newProps.config` was set to either null or undefined was not being considered. This caused errors when calling `isDeepEqual` and also when trying to get the `panAndZoom` property during `transform` initialization.
    @LonelyPrincess
    LonelyPrincess committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    9279a3f View commit details
    Browse the repository at this point in the history