🔧 Configured new eslintrules

danieldelcore · Jul 23, 2020 · 957951b · 957951b
1 parent fa15082
commit 957951b
Show file tree

Hide file tree

Showing 6 changed files with 165 additions and 76 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -6,6 +6,7 @@ module.exports = {
         'plugin:@typescript-eslint/recommended',
         'prettier/@typescript-eslint',
         'plugin:prettier/recommended',
+        'plugin:jsx-a11y/recommended',
     ],
     plugins: ['import', 'jsx-a11y', 'react', 'react-hooks'],
     parserOptions: {
@@ -32,4 +33,5 @@ module.exports = {
             version: 'detect',
         },
     },
+    ignorePatterns: ['dist', 'node_modules'],
 };
diff --git a/examples/0_Palette.tsx b/examples/0_Palette.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable jsx-a11y/accessible-emoji */
 /** @jsx jsx */
 import { storiesOf } from '@storybook/react';
 import { useState } from 'react';

diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
         "@typescript-eslint/eslint-plugin": "^1.4.2",
         "@typescript-eslint/parser": "^1.4.2",
         "babel-loader": "^8.0.6",
-        "eslint": "^5.15.1",
+        "eslint": "^7.5.0",
         "eslint-config-prettier": "^4.1.0",
         "eslint-plugin-import": "^2.22.0",
         "eslint-plugin-jsx-a11y": "^6.3.1",

diff --git a/packages/components/select/Select.tsx b/packages/components/select/Select.tsx
@@ -42,7 +42,7 @@ const Select: FC<SelectProps> = props => {
             className={classNames}
             id={props.id}
             name={props.name}
-            onChange={props.onChange}
+            onBlur={props.onChange}
             value={props.value || props.defaultValue}
             disabled={props.disabled}
         >

diff --git a/packages/components/tabs/TabList.tsx b/packages/components/tabs/TabList.tsx
@@ -37,6 +37,7 @@ const TabList: FC<TabListProps> = ({ label, children }) => {
     return (
         <div
             role="tablist"
+            tabIndex={0}
             aria-label={label}
             onKeyDown={onKeyDown}
             css={css`