Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename types.isClosure #39

Open
daniele-rapagnani opened this issue Jan 7, 2021 · 3 comments
Open

Rename types.isClosure #39

daniele-rapagnani opened this issue Jan 7, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daniele-rapagnani
Copy link
Owner

It's probably best to rename types.isClosure to types.isFunction. Even if they are called Closures by the VM they are Functions for the end-user.
@daniele-rapagnani daniele-rapagnani added enhancement New feature or request good first issue Good for newcomers labels Jan 7, 2021
@Siddharth1010
Copy link

@daniele-rapagnani In which file does the issue lie?

@daniele-rapagnani
Copy link
Owner Author

daniele-rapagnani commented Jan 7, 2021 •
edited
Loading

Hey @Siddharth1010 , you can find it in types_module.c. It should be as simple as renaming it there and possibly in some of the unit tests, I suspect only in the ones pertaining to the types module itself.

@NathanGugel
Copy link
Contributor

Hey @Siddharth1010! I was wondering if you still wanted to fix this issue? I'm working on another issue related to the types module, so I wanted to check. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniele-rapagnani @NathanGugel @Siddharth1010