close #236 (Integer overflow warning detected by clang++)

daniele77 · Apr 3, 2024 · af87753 · af87753
1 parent ee14ce0
commit af87753
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/examples/pluginmanager.cpp b/examples/pluginmanager.cpp
@@ -98,7 +98,7 @@ class PluginContainer
     {
         auto p = PluginRegistry::Instance().Create(plugin, menu);
         if (p)
-            plugins.push_back(move(p));
+            plugins.push_back(std::move(p));
     }
     void Unload(const string& plugin)
     {
@@ -187,7 +187,7 @@ class Arithmetic : public RegisteredPlugin<Arithmetic, ArithmeticName>
                 },
                 "Print the result of a subtraction" );
 
-        menuHandler = menu->Insert(move(subMenu));
+        menuHandler = menu->Insert(std::move(subMenu));
     }
     ~Arithmetic() override
     {
@@ -237,7 +237,7 @@ class Strings : public RegisteredPlugin<Strings, StringsName>
                 out << "\n";
             },
             "Alphabetically sort a list of words" );
-        menuHandler = menu->Insert(move(subMenu));
+        menuHandler = menu->Insert(std::move(subMenu));
     }
     ~Strings() override
     {

diff --git a/include/cli/detail/fromstring.h b/include/cli/detail/fromstring.h
@@ -131,7 +131,7 @@ inline T signed_from_string(std::string s)
     {
         s = s.substr(1);
         const U val = unsigned_digits_from_string<U>(s);
-        const auto min = std::numeric_limits<T>::min(); // this to avoid overflow warnings
+        auto min = std::numeric_limits<T>::min(); // this to avoid overflow warnings. Please NOTE: const auto produces warning!
         if ( val > static_cast<U>( - min ) )
             throw bad_conversion();
         return (- static_cast<T>(val));