Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake dependency handling broken #117

Closed
jobrud opened this issue Jun 18, 2021 · 0 comments
Closed

CMake dependency handling broken #117

jobrud opened this issue Jun 18, 2021 · 0 comments
Assignees
Milestone

Comments

@jobrud
Copy link
Contributor

jobrud commented Jun 18, 2021

When the library is built for boost asio usage (with -DCLI_UseBoostAsio=ON) Boost::System is added to public link interface. That means all applications or other libraries which get linked against cli obtain automatically those dependency. Adding Boost::System to the link interface should be correct but then the cli cmake package also should take care about that dependency with:

find_dependency(Boost REQUIRED COMPONENTS system)

Which was commented out in commit fab1d75.

@daniele77 daniele77 self-assigned this Jun 18, 2021
@daniele77 daniele77 added this to the Release 1.3 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants