Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement redis commands APPEND, properly implement the SET command, implement SET command variations (e.g. SETNX and so on) #126

Closed
danielealbano opened this issue Jul 3, 2022 · 0 comments · Fixed by #164, #190, #191, #192 or #193
Closed

Implement redis commands APPEND, properly implement the SET command, implement SET command variations (e.g. SETNX and so on) #126

danielealbano opened this issue Jul 3, 2022 · 0 comments · Fixed by #164, #190, #191, #192 or #193
Assignees
@danielealbano
Labels
enhancement New feature or request
Projects
cachegrand
Milestone
v0.2

Comments

@danielealbano
Copy link
Owner

danielealbano commented Jul 3, 2022 •
edited

Implement redis commands APPEND, properly implement the SET command, implement SET command variations (e.g. SETNX and so on)

Below the full list of commands to implement

Command Notes
✔ APPEND
✔ COPY Missing DB parameter
✔ DBSIZE
✔ DECR
✔ DECRBY
✔ DEL
✔ EXISTS
✔ EXPIRE
✔ EXPIREAT
✔ EXPIRETIME
✔ FLUSHDB Missing ASYNC parameter
✔ GET
✔ GETDEL
✔ GETEX
✔ GETRANGE
✔ GETSET
✔ HELLO Missing AUTH and SETNAME parameters
✔ INCR
✔ INCRBY
✔ INCRBYFLOAT
✔ KEYS
✔ LCS Missing IDX, MINMATCHLEN and WITHMATCHLEN parameters
✔ MGET
✔ MSET
✔ MSETNX
✔ PERSIST
✔ PEXPIRE
✔ PEXPIREAT
✔ PEXPIRETIME
✔ PING
✔ PSETEX
✔ PTTL
✔ QUIT
✔ RANDOMKEY
✔ RENAME
✔ RENAMENX
✔ SCAN Missing TYPE parameter
✔ SET
✔ SETEX
✔ SETNX
✔ SETRANGE
✔ SHUTDOWN
✔ STRLEN
✔ SUBSTR
✔ TOUCH
✔ TTL
✔ UNLINK
@danielealbano danielealbano created this issue from a note in cachegrand (Ready for Work) Jul 3, 2022
@danielealbano danielealbano added the enhancement New feature or request label Jul 3, 2022
@danielealbano danielealbano added this to the v0.2 milestone Jul 3, 2022
@danielealbano danielealbano linked a pull request Aug 1, 2022 that will close this issue
MGET redis command #164
Merged
@danielealbano danielealbano moved this from Ready for Work to In Progress in cachegrand Aug 22, 2022
@danielealbano danielealbano mentioned this issue Aug 22, 2022
Merged
danielealbano added a commit that referenced this issue Aug 22, 2022
@danielealbano
Implement a set of commands (#190)
c2e17dc 
This PR implements a set of PRs or the issue #126 .

The following commands have been implemented in the following PR

| Command       | Notes                                     |
| ------------- | ----------------------------------------- |
| DBSIZE      |                                           |
| EXISTS      |                                           |
| FLUSHDB     | Missing ASYNC                             |
| GETSET      |                                           |
| LCS         | Missing IDX, MINMATCHLEN and WITHMATCHLEN |
| MSETNX      | Currently buggy, might hang the server    |
| PTTL        |                                           |
| TTL         |                                           |

In addition:
- the DEL command has been refactored to take advantage of the implemented shortcuts
- the HELLO command now reports an error if the AUTH or SETNAME parameters are used as they are currently unsupported
@danielealbano danielealbano linked a pull request Aug 22, 2022 that will close this issue
Implement a set of commands #190
Merged
@danielealbano danielealbano self-assigned this Aug 22, 2022
@danielealbano danielealbano linked a pull request Aug 23, 2022 that will close this issue
Fix LCS behaviour when non existant keys are provided #191
Merged
cachegrand automation moved this from In Progress to Completed Aug 23, 2022
@danielealbano danielealbano moved this from Completed to In Progress in cachegrand Aug 23, 2022
@danielealbano danielealbano reopened this Aug 25, 2022
This was linked to pull requests Aug 25, 2022
Implement new command copy #192
Merged
Expand used redis tests #193
Merged
Implement expire and persist related commands #194
Merged
Implement touch and unlink commands #195
Merged
Implement getrange and setrange #198
Merged
Implement randomkey command #202
Merged
Implement keys command #203
Merged
cachegrand automation moved this from In Progress to Completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielealbano danielealbano

Labels
enhancement New feature or request
Projects
cachegrand
  
Completed
Milestone
v0.2
1 participant
@danielealbano