Very small regex pattern tweak to allow Still to process column names that contain spaces #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
I've been working with Still to validate normalization in a very large tabular database that has spaces in the column names. After working through a panic traceback, it seems like the problem stems solely from the regex pattern in line 82 of schema.go, which matches for any symbol except for ":" to split out the column name from the rule. After altering the pattern so that it splits by ": ", it appears to be working as expected in my tests. Since it's working for me, I figured I'd submit a PR!
Let me know if you have any other questions, and thanks very much for the tool! It has been a huge help to me and the lab I work in.
--Nick