Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very small regex pattern tweak to allow Still to process column names that contain spaces #23

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

nrminor
Copy link
Contributor

@nrminor nrminor commented Jan 8, 2024

Hi Daniel,

I've been working with Still to validate normalization in a very large tabular database that has spaces in the column names. After working through a panic traceback, it seems like the problem stems solely from the regex pattern in line 82 of schema.go, which matches for any symbol except for ":" to split out the column name from the rule. After altering the pattern so that it splits by ": ", it appears to be working as expected in my tests. Since it's working for me, I figured I'd submit a PR!

Let me know if you have any other questions, and thanks very much for the tool! It has been a huge help to me and the lab I work in.

--Nick

@danielecook danielecook merged commit 7c5e9df into danielecook:master Jan 8, 2024
1 check failed
@danielecook
Copy link
Owner

Cool! This looks good, but it looks like my github actions is broken. I'll try to get around to fixing that later. For now you may need to rebuild until I get that addressed.

@nrminor
Copy link
Contributor Author

nrminor commented Jan 8, 2024

No problem! I'm already working with a local build of my fork. Fingers crossed you don't find anything this breaks that I missed. I'm suspicious that this (apparent) fix was so simple!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants