Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH (issue #49): Added DiffusionConvolution, tests and a script to easily build docs locally. #52

Merged
merged 1 commit into from Apr 29, 2020

Conversation

LeviBorodenko
Copy link
Contributor

  • Added DiffusionConvolution to layers.convolutional. Also covered it in tests and made sure the docs look good.
  • Improved docs for SortPool and covered it in globalpool tests (removed from pool tests).
  • Added both SortPool and DiffusionConvolution to autogen.py so it is contained in the docs.
  • added docs/local_build.sh which is a script that installs the current spektral build from the local branch, builds docs and serves them on a local web server.
    For convenience.

…sily build docs locally.

- Added DiffusionConvolution to `layers.convolutional`. Also covered it in tests and made sure the docs look good.
- Improved docs for SortPool and covered it in globalpool tests (removed from pool tests).
- Added both SortPool and DiffusionConvolution to `autogen.py` so it is contained in the docs.
- added `docs/local_build.sh` which is a script that installs the current spektral build from the local branch, builds docs and serves them on a local webserver.
 For convinience.
@danielegrattarola
Copy link
Owner

Thank you very much for adding this!
I think it's good to merge unless you want to make other changes.

@LeviBorodenko
Copy link
Contributor Author

No problem :)

This should be good to merge!

@danielegrattarola danielegrattarola merged commit e5d2be4 into danielegrattarola:develop Apr 29, 2020
@danielegrattarola
Copy link
Owner

Great! Thanks again!!

@LeviBorodenko LeviBorodenko deleted the ENH_DiffConv branch April 29, 2020 13:38
@danielegrattarola
Copy link
Owner

This was merged into master and I also released v0.5.0 of the library on PyPi.

Cheers,
Daniele

danielegrattarola added a commit that referenced this pull request Feb 9, 2021
 ENH (issue #49): Added DiffusionConvolution, tests and a script to easily build docs locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants