Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for 'identity' value in content-encoding header #438

Closed
jadeade opened this issue Oct 19, 2020 · 1 comment
Closed

No support for 'identity' value in content-encoding header #438

jadeade opened this issue Oct 19, 2020 · 1 comment
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone bug
Milestone

Comments

@jadeade
Copy link

jadeade commented Oct 19, 2020

Hi!

I recently found a service that was using 'identity' value for the content-encoding header when downloading a file, and this was generating a content-encoding value not supported exception. Seems that the framework only expects content-encoding to be empty (or no present?) if no decoding is needed

This seems to be an easy fix, I just needed to add to MVCFramework.RESTClient.TRESTClient.SendHTTPCommand an additional check to the line that checks that no decoding is needed:

  if Result.ContentEncoding.IsEmpty or (Result.ContentEncoding = 'identity') then
    Exit;

I am using v3.0 but I checked the current version code and I didn't find this fixed. Could you have a look? Maybe this could be needed to be added in other places on both the client and server side?

I just requested the server owner to use gzip encoding and everything worked fine, just wanted to raise the hand about this

Thanks for the nice work!

@jadeade jadeade changed the title No support for 'identity' value in content encode header No support for 'identity' value in content-encoding header Oct 19, 2020
@danieleteti
Copy link
Owner

Thanks, fixed in the repo

@danieleteti danieleteti self-assigned this Oct 19, 2020
@danieleteti danieleteti added accepted Issue has been accepted and inserted in a future milestone bug labels Oct 19, 2020
@danieleteti danieleteti added this to the 3.2.1-carbon milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone bug
Projects
None yet
Development

No branches or pull requests

2 participants