MVCNameCase improvements #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a quick test and behaved well. But I can put together a test with a large serialization list to find out how it will perform. |
|
OK, good.. and it should be compared to the previous version.
DT
Il giorno ven 16 ott 2020 alle ore 19:22 João Antônio Duarte <
notifications@github.com> ha scritto:
… Did you measured the timing of this new version?
I did a quick test and behaved well. But I can put together a test with a
large serialization list to find out how it will perform.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#437 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK4ZJEF2RJSVC433Y6TGE3SLB6ONANCNFSM4SSVXSMA>
.
--
*Daniele Teti*
CEO & CTO
bit Time Professionals
website [it]: www.bittimeprofessionals.it
website [en]: www.bittimeprofessionals.com
blog: www.danieleteti.it
my last book on leanpub <https://leanpub.com/delphimvcframework>
my previous books on amazon
<https://www.amazon.it/s?i=stripbooks&rh=p_27%3ADaniele+Teti>
mobile: +39 3496626822
office: +39 06 20761499
|
…regex, serialization becomes 6 times slower.
|
I did a serialization test with an extensive list. I found that using the SnakeCase function with regular expression is about 6 times slower. So, I improved the existing SnakeCase function to convert multiple underscores into just one and also add an underscore between word and numeral.
|
|
When improving unit tests I identified the error described in issue #436 and made the correction. |
|
Good! Thank you Joao. RegEx are powerful but quite slow compared in these cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new type of name case serialization:
ncSnakeCaseI saw that there was already a conversion function for the snake case, however it failed to convert multiple underscores to just one. So I switched to regular expression conversion.