Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small XE4 compilation issue and a fix #79

Closed
edwinyzh opened this issue Aug 22, 2023 · 1 comment
Closed

A small XE4 compilation issue and a fix #79

edwinyzh opened this issue Aug 22, 2023 · 1 comment
Assignees
@danieleteti
Labels
accepted Issue has been accepted and inserted in a future milestone
Milestone
1_5_0

Comments

@edwinyzh
Copy link

In LoggerPro.pas, the following line couldn't be compiled under XE4:

procedure TLoggerProAppenderBase.Setup;
begin
  FFormatSettings := LoggerPro.GetDefaultFormatSettings;
end;

Change it as following will fix the XE4 compilation error:
FFormatSettings := GetDefaultFormatSettings;

Thanks!
@engycz
Copy link

engycz commented Sep 27, 2023

Same problem with Delphi 10 Seattle

@danieleteti danieleteti self-assigned this Sep 27, 2023
@danieleteti danieleteti added the accepted Issue has been accepted and inserted in a future milestone label Sep 27, 2023
@danieleteti danieleteti added this to the 1_5_0 milestone Sep 27, 2023
danieleteti added a commit that referenced this issue Sep 27, 2023
@danieleteti
https://github.com/danieleteti/loggerpro/issues/79
657a539
danieleteti added a commit to danieleteti/delphimvcframework that referenced this issue Oct 18, 2023
@danieleteti
Squashed 'lib/loggerpro/' changes from 100b0ce0..0d39e1d1
6900315 
0d39e1d1 New LogLevel: FATAL
5248b9de Improved fileformatname check
657a539d danieleteti/loggerpro#79
67729f57 danieleteti/loggerpro#72
f05a91a6 danieleteti/loggerpro#73
3c805c0f Merge pull request #71 from luebbe/master
3a790459 Fixes #70 Add test to expose #70

git-subtree-dir: lib/loggerpro
git-subtree-split: 0d39e1d1549d42fa20b71503eed944043771b7bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieleteti danieleteti

Labels
accepted Issue has been accepted and inserted in a future milestone
Projects
None yet
Milestone
1_5_0
Development

No branches or pull requests
3 participants
@edwinyzh @danieleteti @engycz