Refactor string escaping!

danielevans · Dec 28, 2011 · b2ee6d1 · b2ee6d1
1 parent 9ae7463
commit b2ee6d1
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/mini_magick.rb b/lib/mini_magick.rb
@@ -459,7 +459,7 @@ def +(*options)
       push(@args.pop.gsub(/^-/, '+'))
       if options.any?
         options.each do |o|
-          push "\"#{ o }\""
+          push escape_string(o)
         end
       end
     end
@@ -468,10 +468,14 @@ def add(command, *options)
       push "-#{command}"
       if options.any?
         options.each do |o|
-          push "\"#{ o }\""
+          push escape_string(o)
         end
       end
     end
+
+    def escape_string(value)
+      '"' + value + '"'
+    end
 
     def push(arg)
       @args << arg.to_s.strip