Register mandatory and non-mandatory env vars #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasgomide
force-pushed
the
log-env
branch
2 times, most recently
from
3aaf3e0
to
6512a16
Compare
danielfireman
requested changes
Oct 2, 2018
server/web/main.go
Outdated
| // Specification represents a map of enviornment variables | ||
| type Specification struct { | ||
| UserPassword string `envconfig:"USERPASSWD" required:"true"` | ||
| EncryptionKey string `split_words:"true" required:"true"` |
There was a problem hiding this comment.
Nit: Better to use envconfig:"ENCRYPTION_KEY" than split_words (which ends up doing the same thing, but indirectly).
Same bellow.
| } | ||
| key := []byte(os.Getenv("ENCRYPTION_KEY")) | ||
|
|
There was a problem hiding this comment.
Log the environment variables/config?
fmt.Printf("%+v", spec) ?
There was a problem hiding this comment.
I forgot to log it.. dammit
|
@danielfireman done (: |
|
Thanks a lot, @lucasgomide ! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit closes issue #21
This change is