Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize MavenReleasePluginMessageFilter to support custom prefix #18

Open
ittaiz opened this issue Nov 3, 2013 · 3 comments
Open

Comments

@ittaiz
Copy link

ittaiz commented Nov 3, 2013

Hi,
I have a homebrew mechanism similar to the maven release plugin which adds its own commits.
I'd like to change the extract a filter from the MavenReleasePluginMessageFilter which accepts a prefix (the current filter will call that one with "[maven-release-plugin]") and so one can define a prefix which it wants to filter.

@danielflower
Copy link
Owner

Hi, that sounds useful. As long as by default it filters out maven release commits, then it would be great to have this.

@ittaiz
Copy link
Author

ittaiz commented Nov 3, 2013

looking at the GenerateMojo class it seems that it currently just uses a closed list of filters.
I can do the above change pretty easily if i just expose a config value with a default value for the release plugin but i think the better approach should be to check if the custom filter prefix is configured and if so register an additional filter.
What do you think?

Of course in the generate mojo the Generator will be constructed with the default list (including the current maven release plugin filter) and optionally the new filter

@danielflower
Copy link
Owner

Yes, your idea of adding a filter if there is a custom prefix sounds good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants