Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external providers #116

Merged
merged 6 commits into from
Apr 14, 2024

Conversation

restanrm
Copy link
Contributor

@restanrm restanrm commented Mar 12, 2024

I would like to propose to add 2 providers in this PullRequest. If you prefer to have a PR per provider I could do it as well.

The providers added are Scaleway and OVH

Copy link
Owner

@danielfoehrKn danielfoehrKn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy cow, thank you very much for that contribution (in my review, I did not see anything wrong with it code-wise). I appreciate you very much. I apologize for the long delay.

As I don't have Scaleway or OVH accounts, I will have to rely on the community to try it out. From what I see from the code it looks great.

@danielfoehrKn danielfoehrKn merged commit d20121c into danielfoehrKn:master Apr 14, 2024
@danielfoehrKn
Copy link
Owner

Btw, I would appreciate it if you would add a small documentation for the Scaleway provider like you did for OVH. This way people can use the provider more easily. No hurry though.

@restanrm
Copy link
Contributor Author

Btw, I would appreciate it if you would add a small documentation for the Scaleway provider like you did for OVH. This way people can use the provider more easily. No hurry though.

Thank you for you review. I wanted to add it to this PR but could not find time to do it and then later forgot about it. I will add the documentation as soon as possible !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants