Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feature: Add support for python markdown and image attachments #84

Closed
wants to merge 1 commit into from

Conversation

jaycode
Copy link

@jaycode jaycode commented Apr 28, 2018

I updated the code to work with Python Markdown extension:

https://github.com/ipython-contrib/jupyter_contrib_nbextensions/tree/master/src/jupyter_contrib_nbextensions/nbextensions/python-markdown

It will likely work with other Jupyter extensions as well since it uses jupyter nbconvert shell command to get content now.

I also adjusted the code so that the system copies all images to output directory. It does not currently work with attachments since I do not use them myself. To include image, use the following Markdown syntax:

![image](image.url.jpg)

@jaycode
Copy link
Author

jaycode commented May 5, 2018

Issue reference:
#86

@jaycode jaycode closed this May 5, 2018
@jaycode jaycode reopened this May 5, 2018
@danielfrg
Copy link
Owner

Thanks for the PR! I would like to support those extensions. I have not updated this in a while so i have a few questions.

Does it still work with the CSS tricks I am using? Is the HTMLExporter is now basically ignored? I would love to find a way to support the extensions without the explicit subcall. I will try to test this soon.

@danielfrg danielfrg closed this Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants