Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage build fails with incompatible deployment target #36

Open
kkalisz opened this issue Mar 14, 2020 · 1 comment
Open

Carthage build fails with incompatible deployment target #36

kkalisz opened this issue Mar 14, 2020 · 1 comment

Comments

@kkalisz
Copy link

kkalisz commented Mar 14, 2020

Hi,
I have trouble with using Charts Realm alongside with carthage. I'm getting exception during build:
Checkouts/ChartsRealm/ChartsRealm/Classes/Data/RealmBarDataSet.swift:14:8: error: compiling for iOS 8.0, but module 'Charts' has a minimum deployment target of iOS 8.4:

I think it's expected behaviour with current configuration, as I checked project settings
Charts 3.4.0 = iPhone Deployment target is 8.4
Charts Realm 3.4.0 = iPhone Deployment target is 8.0

So indeed it should not compile because child dependency has bigger target value than library itself,
and Carthage is honoring deployment target from project settings

I think that changing deployment target for ChartsReam to 8.4 should fix issue.
I can prepare PR, just let me know what you think about that.

Best Regards

@kkalisz kkalisz changed the title Carthage build fails with incompatible deploayment targest Carthage build fails with incompatible deployment target Mar 15, 2020
@liuxuan30
Copy link
Collaborator

is it from master? I didn't realize such issue there. If this is the truth, I would appreciate if you can create an PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants