Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate ChartsRealmDemo and bugfix #12

Merged
merged 1 commit into from
Oct 24, 2017
Merged

migrate ChartsRealmDemo and bugfix #12

merged 1 commit into from
Oct 24, 2017

Conversation

liuxuan30
Copy link
Collaborator

@liuxuan30 liuxuan30 commented Oct 17, 2017

  1. upgrade ChartsRealmDemo to swift 4
  2. fix CGAffineTransformInvert: singular matrix warning. data setter and zoom() order is reversed

2. fix CGAffineTransformInvert: singular matrix warning. data setter and zoom() order is reversed
@liuxuan30
Copy link
Collaborator Author

liuxuan30 commented Oct 17, 2017

@petester42 I don't see Xcode warns me about @objc use when SWIFT_SWIFT3_OBJC_INFERENCE is on, and it works as usual without any warning throw out at run time. Does this mean we don't have to add @objc for classes such as BalloonMarker, XYMarkerView, RadarMarkerView, LargeValueFormatter, which are the only swift classes?

@pmairoldi
Copy link
Collaborator

The problem I had was that when using the new “minimize interface” that the objective-c code didn’t get acess to all the properties it needed. If you able to make stuff work without it go ahead.

@liuxuan30
Copy link
Collaborator Author

I'm not sure neither, as Xcode have no complain and works as usual.I clicked every realm demo chart and no crash at all. It seems all demo charts don't use marker at all. So @objc is not a must?

@pmairoldi
Copy link
Collaborator

If it works then whatever. We can revisit it if it stops working.

@pmairoldi
Copy link
Collaborator

Merge whenever you’re ready.

@liuxuan30 liuxuan30 merged commit df28714 into master Oct 24, 2017
@liuxuan30 liuxuan30 deleted the RealmDemo branch January 4, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants