Swift 4 Support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxuan30
reviewed
Oct 9, 2017
| @@ -10,6 +10,6 @@ Pod::Spec.new do |s| | |||
| s.osx.deployment_target = "10.11" | |||
| s.source = { :git => "https://github.com/danielgindi/ChartsRealm.git", :tag => "v#{s.version}" } | |||
| s.source_files = "ChartsRealm/Classes/**/*.swift" | |||
| s.dependency "Charts", "3.0.3" | |||
| s.dependency "Charts", "3.0.4" | |||
| s.dependency "RealmSwift", "~> 2.10" | |||
There was a problem hiding this comment.
shall we bump to 2.10.2 as well though it should be fine?
There was a problem hiding this comment.
No. We should leave it. All versions of 2.10 should be API compatible.
There was a problem hiding this comment.
making sure everything still builds and the pod validates then ill merge
There was a problem hiding this comment.
sure. good to go then. My carthage update always timeout after a long time downloading realm swift :(
There was a problem hiding this comment.
You should use the build command when testing. It's carthage build --no-skip-current. Just builds stuff from checkout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates code to swift 4.