Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Resource Attributes #105

Merged
merged 2 commits into from May 6, 2015
Merged

Conversation

Protossoario
Copy link
Contributor

Modified the base template to add a table-like structure for the Attributes section of a Resource, if added.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.63% when pulling ac38d02 on Protossoario:master into b94a662 on danielgtaylor:master.

@wyattjoh
Copy link

wyattjoh commented May 5, 2015

What's the ETA on this PR?

@danielgtaylor
Copy link
Owner

@wyattjoh I'm looking at it today, will try to get it in (maybe update the example) and push a release if everything is good.

@danielgtaylor
Copy link
Owner

@Protossoario thanks for this pull request. I'm going to merge it in, but before doing another release I'd really like to 1. add support for attributes in more places and 2. support nested structures & arrays. Work is underway to make these a bit easier but it's probably still a couple weeks away from implementation.

Edit: to anybody finding this PR, the only way to make it work is to set attributes in the resource section:

# My API

## Question [/questions/{id}]

+ Parameters
    + id: `abc123` (required) - Unique question identifier

+ Attributes
    + title (required) -  Short question overview
    + body - Full question description

### Get a question [GET]

+ Response 200

danielgtaylor added a commit that referenced this pull request May 6, 2015
@danielgtaylor danielgtaylor merged commit 988eca4 into danielgtaylor:master May 6, 2015
@Protossoario
Copy link
Contributor Author

@danielgtaylor yeah, I thought about adding support for nested structures, but couldn't figure out a quick way to present them neatly.

@danielgtaylor
Copy link
Owner

@Protossoario yeah, it's more difficult than it initially seems. I'm still working on coming up with a good presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants