Accept -p option for local server port #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,7 @@ parser = require('optimist') | |||
| .options('o', alias: 'output', describe: 'Output file') | |||
| .options('t', alias: 'template', describe: 'Template name or file', default: 'default') | |||
| .options('s', alias: 'server', describe: 'Start a local preview server') | |||
| .options('p', alias: 'port', describe: 'Port for local preview server', default: '3000') | |||
There was a problem hiding this comment.
Shouldn't the default here be a number rather than a string? It looks like the http module coerces it to the proper type but I believe the correct way to do it is with a number.
There was a problem hiding this comment.
Yes, I agree. I was thinking I'd match the string format of argv, but an integer is more appropriate. Updated.
|
This looks great, thanks! |
danielgtaylor
added a commit
that referenced
this pull request
Nov 27, 2013
Accept -p option for local server port. Fixes #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome project! I'm using this to document an API written in Rails so I've found it useful to run the server on a port other than 3000.