Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #41 broken example links #42

Closed
wants to merge 2 commits into from
Closed

Fix #41 broken example links #42

wants to merge 2 commits into from

Conversation

milieu
Copy link
Contributor

@milieu milieu commented Jul 11, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4cc645e on milieu:master into b12c0c6 on danielgtaylor:master.

@@ -212,7 +212,7 @@ <h4 id="tags-">Resources&nbsp;<a href="#page:tags,header:tags-"><i class="fa fa-
</div><ul class="list-group"><li class="list-group-item"><strong>Response&nbsp;&nbsp;<code>200</code></strong></li></ul></section><h4 id="tags-get-one-tag">Get one tag&nbsp;<a href="#page:tags,header:tags-get-one-tag"><i class="fa fa-link"></i></a></h4><p>Get a single tag</p>
<section id="tags-get-one-tag-get" class="panel panel-info"><div class="panel-heading"><div style="float:left"><a href="#page:tags,header:tags-get-one-tag-get" class="btn btn-xs btn-info">GET</a></div><div style="overflow:hidden"><code>/tags/{id}</code></div></div><ul class="list-group"><li class="list-group-item"><strong>Response&nbsp;&nbsp;<code>200</code></strong></li></ul></section></div></div><a href="#page:users" class="btn btn-default"><i class="fa fa-arrow-circle-left"></i> Previous</a><div class="clearfix"></div><hr></div></div></div></div><p style="text-align: center;" class="text-muted">Generated by&nbsp;<a href="https://github.com/danielgtaylor/aglio" class="aglio">aglio</a>&nbsp;on 22 Mar 2014</p><div id="localFile" style="display: none; position: absolute; top: 0; left: 0; width: 100%; color: white; background: red; font-size: 150%; text-align: center; padding: 1em;">This page may not display correctly when opened as a local file. Instead, view it from a web server.

</div></body><script src="//code.jquery.com/jquery-1.11.0.min.js"></script><script src="//netdna.bootstrapcdn.com/bootstrap/3.1.1/js/bootstrap.min.js"></script><script>(function() {
</div></body><script src="http://code.jquery.com/jquery-1.11.0.min.js"></script><script src="http://netdna.bootstrapcdn.com/bootstrap/3.1.1/js/bootstrap.min.js"></script><script>(function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links should stay the way they are. The reason is that they will match the protocol currently used on the page - either http or https and so it prevents potential security issues in some browsers that warn when non-secure content is loaded on a secure page. See:

http://www.paulirish.com/2010/the-protocol-relative-url/

@danielgtaylor
Copy link
Owner

I've merged in the part which fixes #41 in 36f6ce8

Closing this issue for now since we want to keep protocol-relative URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants